From 3d09555c6c4dbb29cad1de9525d63cb5726794f6 Mon Sep 17 00:00:00 2001 From: Nick Briggs Date: Tue, 21 Oct 2025 18:04:40 -0700 Subject: [PATCH] Removes assigned-but-not-used rval in DSK_getfilename and redundant test of current_len in conc_dir_and_name --- src/dsk.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/dsk.c b/src/dsk.c index 7b3c464..0074cfa 100644 --- a/src/dsk.c +++ b/src/dsk.c @@ -965,7 +965,7 @@ LispPTR DSK_getfilename(LispPTR *args) dirp = 1; } else { conc_dir_and_name(dir, name, aname, sizeof(aname)); - if ((rval = true_name(aname, sizeof(aname))) == -1) { + if (true_name(aname, sizeof(aname)) == -1) { strlcpy(vname, aname, sizeof(vname)); dirp = 1; } else { @@ -995,7 +995,7 @@ LispPTR DSK_getfilename(LispPTR *args) dirp = 0; } else { conc_dir_and_name(dir, name, aname, sizeof(aname)); - if ((rval = true_name(aname, sizeof(aname))) == -1) { + if (true_name(aname, sizeof(aname)) == -1) { strlcpy(vname, aname, sizeof(vname)); dirp = 1; } else { @@ -2561,7 +2561,7 @@ void conc_dir_and_name(char *dir, char *name, char *fname, size_t fname_size) current_len = strlen(fname); /* Ensure the directory has a final slash */ - if ((current_len == 0) || (current_len > 0 && fname[current_len - 1] != '/')) { + if ((current_len == 0) || (fname[current_len - 1] != '/')) { strlcat(fname, "/", fname_size); }