From 4dfbdf27ffd5c38a578393018de5f61d7965bdd8 Mon Sep 17 00:00:00 2001 From: Nick Briggs Date: Mon, 20 Oct 2025 16:07:36 -0700 Subject: [PATCH] Responds to Gemini review of potential buffer overflows in quote_... fns --- src/dir.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/src/dir.c b/src/dir.c index e4d24fb..4653ac1 100644 --- a/src/dir.c +++ b/src/dir.c @@ -259,6 +259,10 @@ static int quote_fname(char *file, size_t filesize) cp = file; dp = fbuf; + /* safety check for overflow - highly unlikely! */ + if (strlen(file) * 2 + 1 > sizeof(fbuf)) { + return (0); + } while (*cp) { switch (*cp) { case '>': @@ -344,6 +348,10 @@ static int quote_fname_ufs(char *file, size_t filesize) cp = file; dp = fbuf; + /* safety check for overflow - highly unlikely! */ + if (strlen(file) * 2 + 1 > sizeof(fbuf)) { + return (0); + } while (*cp) { switch (*cp) { case '>': @@ -419,6 +427,10 @@ static int quote_dname(char *dir, size_t dirsize) cp = dir; dp = fbuf; + /* safety check for overflow - highly unlikely! */ + if (strlen(dir) * 2 + 1 > sizeof(fbuf)) { + return (0); + } while (*cp) { switch (*cp) { case '>':