github.com/Interlisp.maiko
1
0
Fork 0
mirror of https://github.com/Interlisp/maiko.git synced 2026-05-04 07:19:21 +00:00
Code Issues Projects Releases Wiki Activity

integer multiply overflow wasn't catching all cases (#100)

Browse Source
This commit is contained in:
Larry Masinter
2020-12-18 21:29:18 -08:00
committed by GitHub
parent d4f72d96e1
commit 761ab8cac6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/arith4.c
View File

@@ -61,7 +61,7 @@ dummy:
#else #else
result = arg1 * arg2; result = arg1 * arg2;
if ((arg2 != 0) && ((result / arg2) != arg1)) goto doufn2; if ((arg2 != 0) && (((result % arg2) != 0) || ((result / arg2) != arg1))) goto doufn2;
N_ARITH_SWITCH(result); N_ARITH_SWITCH(result);
#endif #endif
@@ -91,7 +91,7 @@ dummy:
/* UB: signed integer overflow: 1073741824 * 32768 cannot be represented in type 'int' */ /* UB: signed integer overflow: 1073741824 * 32768 cannot be represented in type 'int' */
result = arg1 * arg2; result = arg1 * arg2;
if ((arg2 != 0) && ((result / arg2) != arg1)) { goto doufn; } if ((arg2 != 0) && (((result % arg2) != 0) || ((result / arg2) != arg1))) { goto doufn; }
N_ARITH_SWITCH(result); N_ARITH_SWITCH(result);
#endif #endif