From a42189fb8ba9d5e4400e7f31ee121e08a7b18ebc Mon Sep 17 00:00:00 2001 From: Bruce Mitchener Date: Wed, 20 Jan 2021 00:28:40 +0700 Subject: [PATCH] conspage: Fix uninitialized memory read. (#242) If `prior` was not set, then `priorpg` would be uninitialized and was subsequently used in a comparison. It should be initialized to `NULL`. --- src/conspage.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/conspage.c b/src/conspage.c index e5b7dff..25e0f14 100644 --- a/src/conspage.c +++ b/src/conspage.c @@ -132,6 +132,7 @@ struct conspage *next_conspage(void) { init_conspage(page2, 0); /* No next page */ init_conspage(page1, LPAGE_from_68k(page2)); + priorpg = NULL; prior = 0; for (pg = (struct conspage *)Addr68k_from_LPAGE(next = ListpDTD->dtd_nextpage); next && (next != CONSPAGE_LAST);