From ade0e7d4a600f72cebe553753593897cf0ac23b2 Mon Sep 17 00:00:00 2001 From: Nick Briggs Date: Sat, 19 Dec 2020 10:00:57 -0800 Subject: [PATCH] Revert "integer multiply overflow wasn't catching all cases (#100)" (#101) This reverts commit 761ab8cac6fd4e64f3ad6897c17e375acf5d75e5. --- src/arith4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arith4.c b/src/arith4.c index a7b574a..bd84dab 100644 --- a/src/arith4.c +++ b/src/arith4.c @@ -61,7 +61,7 @@ dummy: #else result = arg1 * arg2; - if ((arg2 != 0) && (((result % arg2) != 0) || ((result / arg2) != arg1))) goto doufn2; + if ((arg2 != 0) && ((result / arg2) != arg1)) goto doufn2; N_ARITH_SWITCH(result); #endif @@ -91,7 +91,7 @@ dummy: /* UB: signed integer overflow: 1073741824 * 32768 cannot be represented in type 'int' */ result = arg1 * arg2; - if ((arg2 != 0) && (((result % arg2) != 0) || ((result / arg2) != arg1))) { goto doufn; } + if ((arg2 != 0) && ((result / arg2) != arg1)) { goto doufn; } N_ARITH_SWITCH(result); #endif