github.com/lowobservable.coax
1
0
Fork 0
mirror of https://github.com/lowobservable/coax.git synced 2026-04-26 04:08:01 +00:00
Code Issues Projects Releases Wiki Activity

Prefer auto spec and spy where possible in unit tests

Browse Source
This commit is contained in:
Andrew Kay
2021-10-20 09:58:32 -05:00
parent 42c3c51d66
commit bda08de83b
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
pycoax/tests/test_serial_interface.py
View File

@@ -1,5 +1,6 @@
import unittest import unittest
from unittest.mock import Mock, call from unittest.mock import Mock, create_autospec, call
from serial import Serial
import sliplib import sliplib
import context import context
@@ -10,13 +11,13 @@ from coax.exceptions import InterfaceError, ReceiveTimeout
class SerialInterfaceResetTestCase(unittest.TestCase): class SerialInterfaceResetTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self.serial = Mock() self.serial = create_autospec(Serial, instance=True)
self.serial.timeout = None self.serial.timeout = None
self.interface = SerialInterface(self.serial) self.interface = SerialInterface(self.serial)
self.interface._write_message = Mock() self.interface._write_message = Mock(wraps=self.interface._write_message)
self.interface._read_message = Mock(return_value=bytes.fromhex('01 32 70')) self.interface._read_message = Mock(return_value=bytes.fromhex('01 32 70'))
def test_message_is_sent(self): def test_message_is_sent(self):
@@ -81,13 +82,13 @@ class SerialInterfaceResetTestCase(unittest.TestCase):
class SerialInterfaceTransmitReceiveTestCase(unittest.TestCase): class SerialInterfaceTransmitReceiveTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self.serial = Mock() self.serial = create_autospec(Serial, instance=True)
self.serial.timeout = None self.serial.timeout = None
self.interface = SerialInterface(self.serial) self.interface = SerialInterface(self.serial)
self.interface._write_message = Mock() self.interface._write_message = Mock(wraps=self.interface._write_message)
self.interface._read_message = Mock() self.interface._read_message = Mock()
def test_words_frame(self): def test_words_frame(self):
@@ -208,11 +209,11 @@ class SerialInterfaceTransmitReceiveTestCase(unittest.TestCase):
class SerialInterfaceReadMessageTestCase(unittest.TestCase): class SerialInterfaceReadMessageTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self.serial = Mock() self.serial = create_autospec(Serial, instance=True)
self.interface = SerialInterface(self.serial) self.interface = SerialInterface(self.serial)
self.interface.slip_serial = Mock() self.interface.slip_serial = Mock(wraps=self.interface.slip_serial)
def test(self): def test(self):
# Arrange # Arrange
@@ -258,11 +259,11 @@ class SerialInterfaceReadMessageTestCase(unittest.TestCase):
class SerialInterfaceWriteMessageTestCase(unittest.TestCase): class SerialInterfaceWriteMessageTestCase(unittest.TestCase):
def setUp(self): def setUp(self):
self.serial = Mock() self.serial = create_autospec(Serial, instance=True)
self.interface = SerialInterface(self.serial) self.interface = SerialInterface(self.serial)
self.interface.slip_serial = Mock() self.interface.slip_serial = Mock(wraps=self.interface.slip_serial)
def test(self): def test(self):
# Act # Act