From 409457dffc50550b4fcabbcd67fb09c11f6d6903 Mon Sep 17 00:00:00 2001
From: Mikael Pettersson <mikpelinux@gmail.com>
Date: Wed, 22 Jul 2020 23:46:23 +0200
Subject: [PATCH] sim: sim_boolean: handle ANDB, add unit test

---
 erlang/apps/sim/src/sim_boolean.erl        | 23 ++++++++++++++++++++++
 erlang/apps/sim/src/sim_core.erl           |  1 +
 erlang/apps/sim/test/sim_boolean_tests.erl | 13 ++++++++++++
 3 files changed, 37 insertions(+)

diff --git a/erlang/apps/sim/src/sim_boolean.erl b/erlang/apps/sim/src/sim_boolean.erl
index 8801d6b..add5eec 100644
--- a/erlang/apps/sim/src/sim_boolean.erl
+++ b/erlang/apps/sim/src/sim_boolean.erl
@@ -25,6 +25,7 @@
 -module(sim_boolean).
 
 -export([ handle_AND/4
+        , handle_ANDB/4
         , handle_ANDI/4
         , handle_ANDM/4
         , handle_SETZ/4
@@ -112,6 +113,28 @@ handle_ANDM_1(Core, Mem, EA, Word) ->
                           fun(Core1, Mem1) -> handle_ANDM_1(Core1, Mem1, EA, Word) end)
   end.
 
+-spec handle_ANDB(#core{}, sim_mem:mem(), IR :: word(), #ea{})
+      -> {#core{}, sim_mem:mem(), {ok, integer()} | {error, {module(), term()}}}.
+handle_ANDB(Core, Mem, IR, EA) ->
+  case sim_core:c(Core, Mem, EA) of
+    {ok, CE} ->
+      AC = IR band 8#17,
+      CA = sim_core:get_ac(Core, AC),
+      Word = CE band CA,
+      handle_ANDB(Core, Mem, AC, EA, Word);
+    {error, Reason} ->
+      sim_core:page_fault(Core, Mem, ea_address(EA), read, Reason,
+                          fun(Core1, Mem1) -> handle_ANDB(Core1, Mem1, IR, EA) end)
+  end.
+
+handle_ANDB(Core, Mem, AC, EA, Word) ->
+  case sim_core:cset(Core, Mem, EA, Word) of
+    {ok, Core1} -> sim_core:next_pc(sim_core:set_ac(Core1, AC, Word), Mem);
+    {error, Reason} ->
+      sim_core:page_fault(Core, Mem, ea_address(EA), write, Reason,
+                          fun(Core1, Mem1) -> handle_ANDB(Core1, Mem1, AC, EA, Word) end)
+  end.
+
 %% Miscellaneous ===============================================================
 
 ea_address(#ea{section = Section, offset = Offset}) ->
diff --git a/erlang/apps/sim/src/sim_core.erl b/erlang/apps/sim/src/sim_core.erl
index 59482ea..f058740 100644
--- a/erlang/apps/sim/src/sim_core.erl
+++ b/erlang/apps/sim/src/sim_core.erl
@@ -260,6 +260,7 @@ dispatch(Core, Mem, IR, EA) ->
     8#404 -> sim_boolean:handle_AND(Core, Mem, IR, EA);
     8#405 -> sim_boolean:handle_ANDI(Core, Mem, IR, EA);
     8#406 -> sim_boolean:handle_ANDM(Core, Mem, IR, EA);
+    8#407 -> sim_boolean:handle_ANDB(Core, Mem, IR, EA);
     _ ->
       PC = (Core#core.pc_section bsl 18) bor Core#core.pc_offset,
       {Core, Mem, {error, {?MODULE, {dispatch, PC, IR, EA}}}}
diff --git a/erlang/apps/sim/test/sim_boolean_tests.erl b/erlang/apps/sim/test/sim_boolean_tests.erl
index f504f92..08900d7 100644
--- a/erlang/apps/sim/test/sim_boolean_tests.erl
+++ b/erlang/apps/sim/test/sim_boolean_tests.erl
@@ -50,6 +50,7 @@
 -define(OP_AND, 8#404).
 -define(OP_ANDI, 8#405).
 -define(OP_ANDM, 8#406).
+-define(OP_ANDB, 8#407).
 
 %% 2.4 Boolean Functions =======================================================
 
@@ -131,6 +132,18 @@ andm_test() ->
          [ {#ea{section = 1, offset = 8#200, islocal = false}, 8#303030} % C(1,,200) = 0,,303030
          ]).
 
+andb_test() ->
+  Prog =
+    [ {1, 8#100, ?INSN(?OP_MOVEI, 1, 0, 0, 8#707070)} % 1,,100/ MOVEI 1,707070
+    , {1, 8#101, ?INSN(?OP_ANDB, 1, 0, 0, 8#200)}     % 1,,101/ ANDB 1,200
+    , {1, 8#102, ?INSN_INVALID}                       % 1,,102/ <invalid>
+    , {1, 8#200, ?COMMA2(-1, 8#333333)}               % 1,,200/ -1,333333
+    ],
+  expect(Prog, [], {1, 8#102}, ?DEFAULT_FLAGS,
+         [ {#ea{section = 1, offset = 8#200, islocal = false}, 8#303030} % C(1,,200) = 0,,303030
+         , {#ea{section = 1, offset = 1, islocal = false}, 8#303030} % AC1 = 0,,303030
+         ]).
+
 %% Common code to run short sequences ==========================================
 
 expect(Prog, ACs, ExpectedPC, ExpectedFlags, ExpectedEs) ->