github.com/open-simh.simh
1
0
Fork 0
mirror of https://github.com/open-simh/simh.git synced 2026-04-30 21:49:00 +00:00
Code Issues Projects Releases Wiki Activity

Cleanup for warning messages produced by the clang C compiler. Mostly adding parentheses in conditional assignments and clarification parentheses in complex boolean expressions.

Browse Source
This commit is contained in:
Mark Pizzolato
2012-04-29 11:59:44 -07:00
parent 3775c17034
commit 0f8e6cfe95
112 changed files with 596 additions and 592 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
I1620/i1620_cpu.c
View File

@@ -476,7 +476,7 @@ while (reason == 0) { /* loop until halted */
saved_PC = PC; /* commit prev instr */
if (sim_interval <= 0) { /* check clock queue */
if (reason = sim_process_event ())
if ((reason = sim_process_event ()))
break;
}

16
I1620/i1620_dp.c
View File

@@ -206,7 +206,7 @@ switch (f1 & ~(FNC_WCH | FNC_NRL)) { /* case on function */
if (psec < 0) /* error? */
CRETIOE (dp_stop, STOP_DACERR);
do { /* loop on count */
if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read sector */
if ((r = dp_rdsec (uptr, psec, qnr, qwc))) /* read sector */
break;
sec++; psec++; /* next sector */
} while ((--cnt > 0) &&
@@ -216,9 +216,9 @@ switch (f1 & ~(FNC_WCH | FNC_NRL)) { /* case on function */
case FNC_TRK: /* read track */
psec = dp_trkop (drv, sec); /* start of track */
for (cnt = 0; cnt < DP_NUMSC; cnt++) { /* full track */
if (r = dp_rdadr (uptr, psec, qnr, qwc)) /* read addr */
if ((r = dp_rdadr (uptr, psec, qnr, qwc))) /* read addr */
break; /* error? */
if (r = dp_rdsec (uptr, psec, qnr, qwc)) /* read data */
if ((r = dp_rdsec (uptr, psec, qnr, qwc))) /* read data */
break; /* error? */
psec = dp_trkop (drv, sec) + ((psec + 1) % DP_NUMSC);
}
@@ -231,9 +231,9 @@ switch (f1 & ~(FNC_WCH | FNC_NRL)) { /* case on function */
if (psec < 0) /* error? */
CRETIOE (dp_stop, STOP_DACERR);
do { /* loop on count */
if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */
if ((r = dp_tstgm (M[dp_ba], qnr))) /* start with gm? */
break;
if (r = dp_wrsec (uptr, psec, qnr)) /* write data */
if ((r = dp_wrsec (uptr, psec, qnr))) /* write data */
break;
sec++; psec++; /* next sector */
} while ((--cnt > 0) &&
@@ -245,11 +245,11 @@ switch (f1 & ~(FNC_WCH | FNC_NRL)) { /* case on function */
return STOP_WRADIS;
psec = dp_trkop (drv, sec); /* start of track */
for (cnt = 0; cnt < DP_NUMSC; cnt++) { /* full track */
if (r = dp_tstgm (M[dp_ba], qnr)) /* start with gm? */
if ((r = dp_tstgm (M[dp_ba], qnr))) /* start with gm? */
break;
if (r = dp_wradr (uptr, psec, qnr)) /* write addr */
if ((r = dp_wradr (uptr, psec, qnr))) /* write addr */
break;
if (r = dp_wrsec (uptr, psec, qnr)) /* write data */
if ((r = dp_wrsec (uptr, psec, qnr))) /* write data */
break;
psec = dp_trkop (drv, sec) + ((psec + 1) % DP_NUMSC);
}

2
I1620/i1620_sys.c
View File

@@ -552,7 +552,7 @@ if (I_GETQP (opfl) != I_M_QNP) { /* Q field allowed? */
cptr = get_glyph (cptr, fptr = gbuf, ' '); /* get flag field */
last = -1; /* none yet */
while (t = *fptr++) { /* loop through */
while ((t = *fptr++)) { /* loop through */
if ((t < '0') || (t > '9')) /* must be digit */
return SCPE_ARG;
t = t - '0'; /* convert */

2
I1620/i1620_tty.c
View File

@@ -260,7 +260,7 @@ do {
*c = 0x7F;
else if ((raw == '~') || (raw == '`')) /* flag? mark */
flg = FLAG;
else if (cp = strchr (tti_to_num, raw)) /* legal? */
else if ((cp = strchr (tti_to_num, raw))) /* legal? */
*c = ((int8) (cp - tti_to_num)) | flg; /* assemble char */
else raw = 007; /* beep! */
tto_write (raw); /* echo */