github.com/open-simh.simh
1
0
Fork 0
mirror of https://github.com/open-simh/simh.git synced 2026-05-03 14:49:02 +00:00
Code Issues Projects Releases Wiki Activity

Intel-Systems: Cleanup Coverity identified issues and address range issues

Browse Source
This commit is contained in:
Bill Beech
2019-10-31 14:53:14 -07:00
parent 82d897712c
commit 58c5fe417f
28 changed files with 451 additions and 606 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Intel-Systems/common/isbc464.c
View File

@@ -33,8 +33,6 @@
#include "system_defs.h"
#define SET_XACK(VAL) (xack = VAL)
/* prototypes */
t_stat isbc064_cfg(uint16 base, uint16 size);
@@ -144,10 +142,12 @@ uint8 isbc464_get_mbyte(uint16 addr)
return (val & 0xFF);
} else {
sim_printf("isbc464_get_mbyte: Out of range\n");
SET_XACK(0); /* bad memory address */
return 0; /* multibus has active high pullups and inversion */
}
}
sim_printf ("isbc464_put_mbyte: Write-Disabled addr=%04X\n", addr);
SET_XACK(0); /* bad memory address */
return 0; /* multibus has active high pullups and inversion */
}
@@ -161,15 +161,17 @@ void isbc464_put_mbyte(uint16 addr, uint8 val)
org = isbc464_unit.u3;
len = isbc464_unit.capac;
if ((addr >= org) && (addr < (org + len))) {
// SET_XACK(1); /* good memory address */
SET_XACK(0); /* bad memory address */
sim_printf ("isbc464_put_mbyte: Read-only Memory\n");
return;
} else {
sim_printf ("isbc464_put_mbyte: Out of range\n");
SET_XACK(0); /* bad memory address */
return;
}
}
sim_printf ("isbc464_put_mbyte: Disabled\n");
SET_XACK(0); /* bad memory address */
}
/* end of isbc464.c */