From cfc59c517f87351df2d50204006e11e801b1c509 Mon Sep 17 00:00:00 2001 From: Mark Pizzolato Date: Tue, 25 Oct 2022 16:41:54 -1000 Subject: [PATCH] makefile: Make gcc and clang warnings fail builds on compile warnings This change allows CI builds to fail without detailed viewing of build output for gcc and clang builds (all modern compilers). Thus forcing PR submitters to find these problems before PRs are merged. This is done by compiling with -Werror for these compilers. We don't know how to do this for other compilers which may be able to use the makefile, so warnings there will still proceed to build successfully. --- makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/makefile b/makefile index db8d2852..24786e4a 100644 --- a/makefile +++ b/makefile @@ -257,6 +257,7 @@ ifeq (${WIN32},) #*nix Environments (&& cygwin) endif endif else + OS_CCDEFS += -Werror ifeq (,$(findstring ++,${GCC})) CC_STD = -std=gnu99 else @@ -264,6 +265,7 @@ ifeq (${WIN32},) #*nix Environments (&& cygwin) endif endif else + OS_CCDEFS += -Werror ifeq (Apple,$(shell ${GCC} -v /dev/null 2>&1 | grep 'Apple' | awk '{ print $$1 }')) COMPILER_NAME = $(shell ${GCC} -v /dev/null 2>&1 | grep 'Apple' | awk '{ print $$1 " " $$2 " " $$3 " " $$4 }') CLANG_VERSION = $(word 4,$(COMPILER_NAME))