github.com/open-simh.simh
1
0
Fork 0
mirror of https://github.com/open-simh/simh.git synced 2026-01-25 11:55:43 +00:00
Code Issues Projects Releases Wiki Activity

GRI, H316, I7094, NOVA, SDS, sigma: Annotate switch case fall through (COVERITY)

Browse Source
This commit is contained in:
Bob Supnik
2017-03-13 10:44:51 -07:00
committed by Mark Pizzolato
parent 6333555947
commit fa62a00fd0
8 changed files with 34 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
sigma/sigma_map.c
View File

@@ -1,6 +1,6 @@
/* sigma_map.c: XDS Sigma memory access routines
Copyright (c) 2007, Robert M Supnik
Copyright (c) 2007-2017, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
@@ -22,6 +22,8 @@
Except as contained in this notice, the name of Robert M Supnik shall not be
used in advertising or otherwise to promote the sale, use or other dealings
in this Software without prior written authorization from Robert M Supnik.
13-Mar-17 RMS Annotated fall through in switch
*/
#include "sigma_defs.h"
@@ -528,6 +530,7 @@ if (QCPU_S89)
break;
case 0xB: /* read sr0, clr */
mem_sr0[memu] = mem_sr1[memu] = 0;
/* fall through */
case 0x8: /* read sr0 */
R[rn] = (wd & S89_SR0_RD) |
(((1u << (chan_num + 1)) - 1) << (S89_SR0_V_PORTS - (chan_num + 1)));
@@ -556,7 +559,8 @@ else switch (CC) { /* 5X0 */
mmc_wlk[ppag | 1] = R[rn] & 0xF;
break;
case 0xC: /* read sr0, clr */
mem_sr0[memu] = 0;
mem_sr0[memu] = 0; /* clr */
/* fall through */
case 0x8: /* read sr0 */
R[rn] = S5X0_SR0_FIXED | (wd & S5X0_SR0_RD) |
(((1u << (chan_num + 1)) - 1) << (S5X0_SR0_V_PORTS - (chan_num + 1)));

7
sigma/sigma_mt.c
View File

@@ -1,6 +1,6 @@
/* sigma_mt.c: Sigma 732X 9-track magnetic tape
Copyright (c) 2007-2008, Robert M. Supnik
Copyright (c) 2007-2017, Robert M. Supnik
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
@@ -25,6 +25,8 @@
mt 7320 and 7322/7323 magnetic tape
13-Mar-17 RMS Annotated fall through in switch
Magnetic tapes are represented as a series of variable records
of the form:
@@ -475,7 +477,8 @@ switch (st) {
case MTSE_FMT: /* illegal fmt */
case MTSE_UNATT: /* not attached */
case MTSE_WRP: /* write protect */
chan_set_chf (mt_dib.dva, CHF_XMME);
chan_set_chf (mt_dib.dva, CHF_XMME); /* set err */
/* fall through */
case MTSE_OK: /* no error */
chan_uen (mt_dib.dva); /* uend */
return SCPE_IERR;