diff --git a/GRI/gri_cpu.c b/GRI/gri_cpu.c index 75af6aba..60c22a19 100644 --- a/GRI/gri_cpu.c +++ b/GRI/gri_cpu.c @@ -509,6 +509,10 @@ while (reason == 0) { /* loop until halted */ case 07: /* src > 0 */ jmp = (t != 0) && !(t & SIGN); break; + + default: /* Impossible Case - Silence Coverity */ + jmp = 0; + break; } if (jmp) { /* jump taken? */ diff --git a/PDP10/pdp10_sys.c b/PDP10/pdp10_sys.c index 25f60e77..f063cde9 100644 --- a/PDP10/pdp10_sys.c +++ b/PDP10/pdp10_sys.c @@ -345,7 +345,7 @@ do { break; case EXE_PDV: /* optional */ - fseek (fileref, bsz * sizeof (d10), SEEK_CUR); /* skip data */ + (void)fseek (fileref, bsz * sizeof (d10), SEEK_CUR);/* skip data */ break; case EXE_VEC: /* entry vec */ @@ -374,7 +374,7 @@ for (i = 0; i < ndir; i = i + 2) { /* loop thru dir */ rpt = ((int32) ((dirbuf[i + 1] >> 27) + 1)) & 0777; /* repeat count */ for (j = 0; j < rpt; j++, mpage++) { /* loop thru rpts */ if (fpage) { /* file pages? */ - fseek (fileref, (fpage << PAG_V_PN) * sizeof (d10), SEEK_SET); + (void)fseek (fileref, (fpage << PAG_V_PN) * sizeof (d10), SEEK_SET); wc = fxread (pagbuf, sizeof (d10), PAG_SIZE, fileref); if (wc < PAG_SIZE) return SCPE_FMT; @@ -424,7 +424,7 @@ else { fmt = FMT_S; else fmt = FMT_R; /* RIM has SA == 0 */ } - fseek (fileref, 0, SEEK_SET); /* rewind */ + (void)fseek (fileref, 0, SEEK_SET); /* rewind */ } switch (fmt) { /* case fmt */ diff --git a/PDP11/pdp11_dup.c b/PDP11/pdp11_dup.c index 537a57fc..8dc3151c 100644 --- a/PDP11/pdp11_dup.c +++ b/PDP11/pdp11_dup.c @@ -1040,7 +1040,7 @@ int32 dup, active, attached; sim_debug(DBG_TRC, DUPDPTR, "dup_poll_svc()\n"); -tmxr_poll_conn(&dup_desc); +(void)tmxr_poll_conn(&dup_desc); tmxr_poll_rx (&dup_desc); tmxr_poll_tx (&dup_desc); for (dup=active=attached=0; dup < dup_desc.lines; dup++) { diff --git a/PDP11/pdp11_rq.c b/PDP11/pdp11_rq.c index 9015d27d..475adf4f 100644 --- a/PDP11/pdp11_rq.c +++ b/PDP11/pdp11_rq.c @@ -2709,7 +2709,7 @@ void rq_ring_int (MSC *cp, struct uq_ring *ring) uint32 iadr = cp->comm + ring->ioff; /* addr intr wd */ uint16 flag = 1; -Map_WriteW (iadr, 2, &flag); /* write flag */ +(void)Map_WriteW (iadr, 2, &flag); /* write flag */ if (cp->s1dat & SA_S1H_VEC) /* if enb, intr */ rq_setint (cp); return; diff --git a/PDP11/pdp11_tq.c b/PDP11/pdp11_tq.c index cae0a228..41e7808c 100644 --- a/PDP11/pdp11_tq.c +++ b/PDP11/pdp11_tq.c @@ -2004,7 +2004,7 @@ void tq_ring_int (struct uq_ring *ring) uint32 iadr = tq_comm + ring->ioff; /* addr intr wd */ uint16 flag = 1; -Map_WriteW (iadr, 2, &flag); /* write flag */ +(void)Map_WriteW (iadr, 2, &flag); /* write flag */ if (tq_dib.vec) /* if enb, intr */ SET_INT (TQ); return; diff --git a/PDP11/pdp11_xq.c b/PDP11/pdp11_xq.c index 1e52089c..66904fc3 100644 --- a/PDP11/pdp11_xq.c +++ b/PDP11/pdp11_xq.c @@ -1822,7 +1822,9 @@ t_stat xq_process_turbo_rbdl(CTLR* xq) xq->var->ReadQ.loss = 0; /* reset loss counter */ } - Map_ReadW (rdra+(uint32)(((char *)(&xq->var->rring[xq->var->rbindx].rmd3))-((char *)&xq->var->rring)), sizeof(xq->var->rring[xq->var->rbindx].rmd3), (uint16 *)&xq->var->rring[xq->var->rbindx].rmd3); + status = Map_ReadW (rdra+(uint32)(((char *)(&xq->var->rring[xq->var->rbindx].rmd3))-((char *)&xq->var->rring)), sizeof(xq->var->rring[xq->var->rbindx].rmd3), (uint16 *)&xq->var->rring[xq->var->rbindx].rmd3); + if (status != SCPE_OK) + return xq_nxm_error(xq); if (xq->var->rring[xq->var->rbindx].rmd3 & XQ_RMD3_OWN) xq->var->rring[i].rmd2 |= XQ_RMD2_EOR; diff --git a/sim_console.c b/sim_console.c index a406035f..2382c98c 100644 --- a/sim_console.c +++ b/sim_console.c @@ -873,7 +873,7 @@ int line = rem->line; if ((!sim_oline) && (sim_log)) { fflush (sim_log); - sim_fseeko (sim_log, sim_rem_cmd_log_start, SEEK_SET); + (void)sim_fseeko (sim_log, sim_rem_cmd_log_start, SEEK_SET); cbuf[sizeof(cbuf)-1] = '\0'; while (fgets (cbuf, sizeof(cbuf)-1, sim_log)) tmxr_linemsgf (lp, "%s", cbuf);