From 2ccf83aaf0ff7eb642af63a9a6f78f2c484868c8 Mon Sep 17 00:00:00 2001 From: Richard Cornwell Date: Thu, 8 Jun 2017 21:57:59 -0400 Subject: [PATCH] I7000: Clean up coverity errors. --- I7000/i7070_cpu.c | 9 +++++---- I7000/i7080_chan.c | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/I7000/i7070_cpu.c b/I7000/i7070_cpu.c index bb36942..aa931a4 100644 --- a/I7000/i7070_cpu.c +++ b/I7000/i7070_cpu.c @@ -235,7 +235,7 @@ t_uint64 ReadP(uint32 addr) { } } } else { - if (addr > MAXMEMSIZE) { + if (addr >= 9990) { switch(addr) { case 9991: return AC[1]; case 9992: return AC[2]; @@ -244,7 +244,7 @@ t_uint64 ReadP(uint32 addr) { } } } - if (addr < MEMSIZE) + if (addr < MEMSIZE && addr < MAXMEMSIZE) return M[addr]; return 0LL; } @@ -260,15 +260,16 @@ void WriteP(uint32 addr, t_uint64 value) { } } } else { - if (addr > MAXMEMSIZE) { + if (addr >= 9990) { switch(addr) { case 9991: AC[1] = value; return; case 9992: AC[2] = value; return; case 9993: AC[3] = value; return; + default: return; } } } - if (addr < MEMSIZE) + if (addr < MEMSIZE && addr < MAXMEMSIZE) M[addr] = value; } diff --git a/I7000/i7080_chan.c b/I7000/i7080_chan.c index e492569..767dc7c 100644 --- a/I7000/i7080_chan.c +++ b/I7000/i7080_chan.c @@ -664,7 +664,7 @@ chan_proc() /* Wrap around if over end of memory, set error */ if (addr > EMEMSIZE) { chan_flags[chan] |= CHS_ERR; - addr -= EMEMSIZE; + /* addr -= EMEMSIZE; */ if (chan_dev.dctrl & cmask) sim_debug(DEBUG_EXP, &chan_dev, "write wrap %d\n", chan); }