1
0
mirror of https://github.com/simh/simh.git synced 2026-01-26 04:01:38 +00:00

Various Magtape Devices: Handle Coverity report of tape error status cases

Coverity flagged one magtape simulator for having fewer case breakouts
than the range of MTSE_x errors, after they were expanded for
MTSE_LEOT (listed as "V4 compatibility") and MTSE_RUNAWAY (for
Dave Bryan's implementation of erase and erase gap).

According to Dave, it turns out that MTSE_RUNAWAY can only be
returned if the magtape simulator supports and implements a density
specification and the ERASE function. The simulators Bob Supnik wrote
don't meet that criteria, so the expanded errors can't be returned.

Simply add a "default" case to the map logic returning SCPE_IERR for
unexpected cases.
This commit is contained in:
Mark Pizzolato
2022-03-13 11:23:11 -07:00
parent 4fa0eaad99
commit 8c325db1ab
10 changed files with 30 additions and 0 deletions

View File

@@ -454,6 +454,9 @@ switch (st) {
case MTSE_BOT: /* reverse into BOT */
uptr->UST = uptr->UST | STA_EOT; /* set err */
break;
default: /* shouldn't happen */
return SCPE_IERR;
} /* end switch */
return SCPE_OK;