github.com/simh.simh
1
0
Fork 0
mirror of https://github.com/simh/simh.git synced 2026-05-03 06:28:41 +00:00
Code Releases Activity

PDP10, PDP11, PDP18B, PDP8: Annotate switch case fall through (COVERITY)

Browse Source
This commit is contained in:
Bob Supnik
2017-03-13 10:59:06 -07:00
committed by Mark Pizzolato
parent fa62a00fd0
commit d1768d2771
6 changed files with 28 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
PDP11/pdp11_rp.c
View File

@@ -1,6 +1,6 @@
/* pdp11_rp.c - RP04/05/06/07 RM02/03/05/80 Massbus disk controller
Copyright (c) 1993-2013, Robert M Supnik
Copyright (c) 1993-2017, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
@@ -25,6 +25,7 @@
rp RH/RP/RM moving head disks
13-Mar-17 RMS Annotated intentional fall through in switch
23-Oct-13 RMS Revised for new boot setup routine
06-Mar-11 MP Converted to using sim_disk library and refactored
for Asynch I/O.
@@ -1171,7 +1172,8 @@ if (!uptr->io_complete) { /* Top End (I/O Initiation) Processing */
mba_set_exc (dibp->ba); /* set exception */
rp_update_ds (DS_ATA, drv); /* set attn */
return SCPE_OK;
}
}
/* fall through */
case FNC_WCHK: /* write check */
case FNC_READ: /* read */
case FNC_READH: /* read headers */

12
PDP11/pdp11_rs.c
View File

@@ -1,6 +1,6 @@
/* pdp11_rs.c - RS03/RS04 Massbus disk controller
Copyright (c) 2013, Robert M Supnik
Copyright (c) 2013-2017, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
@@ -25,6 +25,7 @@
rs RS03/RS04 fixed head disks
13-Mar-17 RMS Annotated intentional fall through in switch
23-Oct-13 RMS Revised for new boot setup routine
*/
@@ -145,7 +146,7 @@
#define RS_LA_OF 7
/* This controller supports many two disk drive types:
/* This controller supports two disk drive types:
type #words/ #sectors/ #tracks/
sector track drive
@@ -353,7 +354,7 @@ switch (ofs) { /* decode PA<5:1> */
break;
case RS_DA_OF: /* RSDA */
rsda[drv] = (uint16)data;
rsda[drv] = (uint16) data;
break;
case RS_AS_OF: /* RSAS */
@@ -361,7 +362,7 @@ switch (ofs) { /* decode PA<5:1> */
break;
case RS_MR_OF: /* RSMR */
rsmr[drv] = (uint16)data;
rsmr[drv] = (uint16) data;
break;
case RS_ER_OF: /* RSER */
@@ -482,10 +483,11 @@ switch (fnc) { /* case on function */
rs_update_ds (DS_ATA, drv); /* set attn */
return SCPE_OK;
}
/* fall through */
case FNC_WCHK: /* write check */
case FNC_READ: /* read */
if (rsda[drv] & DA_INV) { /* bad addr? */
rs_set_er (ER_IAE, drv); /* set error */
rs_set_er (ER_IAE, drv); /* set error */
mba_set_exc (rs_dib.ba); /* set exception */
rs_update_ds (DS_ATA, drv); /* set attn */
break;

4
PDP11/pdp11_tu.c
View File

@@ -1,6 +1,6 @@
/* pdp11_tu.c - PDP-11 TM02/TU16 TM03/TU45/TU77 Massbus magnetic tape controller
Copyright (c) 1993-2013, Robert M Supnik
Copyright (c) 1993-2017, Robert M Supnik
Permission is hereby granted, free of charge, to any person obtaining a
copy of this software and associated documentation files (the "Software"),
@@ -25,6 +25,7 @@
tu TM02/TM03 magtape
13-Mar-17 RMS Annotated fall through in switch
23-Oct-13 RMS Revised for new boot setup routine
18-Apr-11 MP Fixed t_addr printouts for 64b big-endian systems
17-May-07 RMS CS1 DVA resides in device, not MBA
@@ -501,6 +502,7 @@ switch (fnc) { /* case on function */
tufs = tufs & ~(FS_SAT | FS_SSC | FS_ID | FS_ERR);
sim_cancel (uptr); /* reset drive */
uptr->USTAT = 0;
/* fall through */
case FNC_NOP:
tucs1 = tucs1 & ~CS1_GO; /* no operation */
return SCPE_OK;