github.com/simh.simh
1
0
Fork 0
mirror of https://github.com/simh/simh.git synced 2026-01-26 12:02:14 +00:00
Code Releases Activity

makefile: Make gcc and clang warnings fail builds on compile warnings

Browse Source 
This change allows CI builds to fail without detailed viewing of build output
for gcc and clang builds (all modern compilers).  Thus forcing PR submitters
to find these problems before PRs are merged.  This is done  by compiling
with -Werror for these compilers.

We don't know how to do this for other compilers which may be able to use
the makefile, so warnings there will still proceed to build successfully.
This commit is contained in:
Mark Pizzolato
2022-10-25 16:41:54 -10:00
parent c9252d1e42
commit f7112f626f
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
makefile
View File

@@ -309,6 +309,7 @@ ifeq (${WIN32},) #*nix Environments (&& cygwin)
endif
endif
else
OS_CCDEFS += -Werror
ifeq (,$(findstring ++,${GCC}))
CC_STD = -std=gnu99
else
@@ -316,6 +317,7 @@ ifeq (${WIN32},) #*nix Environments (&& cygwin)
endif
endif
else
OS_CCDEFS += -Werror
ifeq (Apple,$(shell ${GCC} -v /dev/null 2>&1 | grep 'Apple' | awk '{ print $$1 }'))
COMPILER_NAME = $(shell ${GCC} -v /dev/null 2>&1 | grep 'Apple' | awk '{ print $$1 " " $$2 " " $$3 " " $$4 }')
CLANG_VERSION = $(word 4,$(COMPILER_NAME))