diff --git a/doc/CHANGELOG.md b/doc/CHANGELOG.md index 37c6c5fc..868dbed6 100644 --- a/doc/CHANGELOG.md +++ b/doc/CHANGELOG.md @@ -47,13 +47,17 @@ The full set of tests is only run for tagged releases. - add pdp11_dmpcnt: performance counters ### Changes -- use for C++ compiles also `-Wpedantic` - sys_w11_n4: reduce cache from 64 to 32 kB to keep timing closure +- changes for DM_STAT_* signals (debug and monitoring) + - DM_STAT_SE: add cpbusy and idec - RtclRw11Unit: fix for clang: M_virt() now public - backend code review: + - use for C++ compiles also `-Wpedantic` - fixes for uninitialized variables (coverity, all uncritical) - - now -Wunused-parameter clean (comment unused params) - - now -Wunused-variable clean (comment so far unused code) + - now -Wunused-parameter clean (comment out unused params) + - now -Wunused-variable clean (comment out so far unused code) + - some selected clang -Weverything aspects + - now -Wdocumentation clean (some wrong doxygen trailing comments) ### Bug Fixes - RtclArgs.hpp: BUGFIX: get *_min limits correct (gcc -Wpedantic) diff --git a/tools/src/librlink/RlinkPacketBufRcv.hpp b/tools/src/librlink/RlinkPacketBufRcv.hpp index a2fa1c7c..90bc9437 100644 --- a/tools/src/librlink/RlinkPacketBufRcv.hpp +++ b/tools/src/librlink/RlinkPacketBufRcv.hpp @@ -1,4 +1,4 @@ -// $Id: RlinkPacketBufRcv.hpp 983 2018-01-02 20:35:59Z mueller $ +// $Id: RlinkPacketBufRcv.hpp 1052 2018-09-30 08:10:52Z mueller $ // // Copyright 2014-2017 by Walter F.J. Mueller // @@ -47,10 +47,10 @@ namespace Retro { void FlushRaw(); enum pkt_state { - kPktPend=0, // // @@ -85,9 +85,9 @@ namespace Retro { int detail=0) const; // some constants (also defined in cpp) - static const int kEof = 0; // // @@ -54,10 +54,10 @@ namespace Retro { public: struct AttnArgs { - uint16_t fAttnPatt; // // @@ -65,7 +65,7 @@ namespace Retro { typedef alist_t::iterator alist_it_t; boost::shared_ptr fspConn; - alist_t fAttnHdl; // // @@ -42,8 +42,8 @@ namespace Retro { Tcl_Command Token() const; // some constants (also defined in cpp) - static const int kOK = TCL_OK; // // @@ -58,8 +58,8 @@ namespace Retro { bool TstMeth(const std::string& name); // some constants (also defined in cpp) - static const int kOK = TCL_OK; // // @@ -59,8 +59,8 @@ namespace Retro { static const uint16_t kPCSR = 004; //!< PCSR reg offset static const uint16_t kPBUF = 006; //!< PBUF reg offset - static const uint16_t kUnit_PR = 0; // // @@ -76,7 +76,7 @@ namespace Retro { std::string fType; //!< drive type bool fEnabled; //!< unit enabled bool fWProt; //!< unit write protected - size_t fCapacity; // // @@ -80,15 +80,15 @@ namespace Retro { virtual void AttachDone(); protected: - bool fTo7bit; // fRcvQueue; // fRcvQueue; //!< input queue + std::string fLogFname; //!< log file name + std::ofstream fLogStream; //!< log file stream + bool fLogOptCrlf; //!< log file: crlf option given + bool fLogCrPend; //!< log file: cr pending + bool fLogLfLast; //!< log file: lf was last char }; } // end namespace Retro diff --git a/tools/src/librw11/Rw11Virt.hpp b/tools/src/librw11/Rw11Virt.hpp index 4a780c27..65b469b3 100644 --- a/tools/src/librw11/Rw11Virt.hpp +++ b/tools/src/librw11/Rw11Virt.hpp @@ -1,4 +1,4 @@ -// $Id: Rw11Virt.hpp 983 2018-01-02 20:35:59Z mueller $ +// $Id: Rw11Virt.hpp 1052 2018-09-30 08:10:52Z mueller $ // // Copyright 2013-2017 by Walter F.J. Mueller // @@ -69,10 +69,10 @@ namespace Retro { }; protected: - Rw11Unit* fpUnit; // // @@ -67,11 +67,11 @@ namespace Retro { }; protected: - size_t fBlkSize; // // @@ -49,7 +49,7 @@ namespace Retro { int RcvPollHandler(const pollfd& pfd); protected: - int fFd; // // @@ -64,9 +64,9 @@ namespace Retro { }; protected: - bool fIStream; // // @@ -86,22 +86,22 @@ namespace Retro { // operation code enum OpCode { - kOpCodeOK = 0, // // @@ -50,7 +50,7 @@ namespace Retro { int RcvPollHandler(const pollfd& pfd); protected: - int fFd; //