diff --git a/bin/xen-create-image b/bin/xen-create-image index d6604cc..ca0d76c 100755 --- a/bin/xen-create-image +++ b/bin/xen-create-image @@ -854,6 +854,11 @@ my $IP_ADDRESSES = ''; my $PASSWORD = ''; +# +# Define some fallback password length +# +my $default_genpass_len = 8; + # Minor helpers for reducing code duplication sub fail ($) { fail_with_config($_[0], \%CONFIG); } @@ -1287,7 +1292,7 @@ sub setupDefaultOptions # Default values for passwords # $CONFIG{ 'genpass' } = 1; - $CONFIG{ 'genpass_len' } = 8; + $CONFIG{ 'genpass_len' } = $default_genpass_len; $CONFIG{ 'password' } = undef; $CONFIG{ 'hash_method' } = 'sha256'; @@ -3961,6 +3966,10 @@ sub setupRootPassword sub generatePassword { my $length = $_[0]; + unless ($length and $length > 0) { + warn "generatePassword: No (sane) password length given. Using $default_genpass_len instead."; + $length = $default_genpass_len; + } my $possible = 'abcdefghijkmnpqrstuvwxyz23456789ABCDEFGHJKLMNPQRSTUVWXYZ'; my $password = ''; while (length($password) < $length) { diff --git a/debian/changelog b/debian/changelog index 7ec0669..eae3fdb 100644 --- a/debian/changelog +++ b/debian/changelog @@ -22,6 +22,7 @@ xen-tools (4.4+dev-1) UNRELEASED; urgency=low + Fix corner cases where not the latest kernel would have been checked. + --password overrides --genpass. (Closes: #764143) Based on patch by Santiago Vila. + + Add password length sanity check with fallback to default length. [ Santiago Vila ] + Fix unaligned maxmem output of xen-create-image. (Closes: #764126)