Nick Briggs
b3f97a85c8
Move misplaced 'break' out of 'if' consequent
2023-02-17 17:01:27 -08:00
Nick Briggs
d95b82ac45
Add (LispPTR) cast to VAG2 macro as this would otherwise produce a signed integer
2023-02-17 17:01:27 -08:00
Nick Briggs
ddc09e09ba
Avoid type conversion from float to double implied by comparison to double 0.0 constant
2023-02-17 17:01:27 -08:00
Nick Briggs
f51d269b1e
Ensure pointers have appropriate type and alignment for data being referenced
2023-02-17 17:01:27 -08:00
Nick Briggs
96fcc9475a
Correct parameter type declaration error for N_OP_ubfloat1
...
Ensure pointers have appropriate alignment for data being referenced
2023-02-17 17:01:27 -08:00
Nick Briggs
c10d339036
Correct various warning: implicit conversion changes signedness (15)
...
Correct various warning: implicit conversion loses integer precision (30)
Correct parameter type declaration error for N_OP_aset1()
Ensure that appropriate types and casts are used in aref_switch()
Remove requirement for declaring "int new" when using aset_switch() macro
2023-02-17 17:01:27 -08:00
Nick Briggs
7aca8bf599
Resolve warning: enumeration values not explicitly handled in switch
2023-02-17 17:01:27 -08:00
Nick Briggs
4a61a3fa6b
Remove unused/obsolete LispWindowFd references/definition
2023-02-17 17:01:27 -08:00
Nick Briggs
c57ae7666d
Resolve warning: no previous extern declaration for non-static variable
2023-02-17 17:01:27 -08:00
Nick Briggs
296ccb3ec9
Resolve warning: variable 'clbp' may be uninitialized when used (it's not, but initialize anyway)
...
Resolve warning: no previous extern declaration for non-static variable (Current_Hot_X, Current_Hot_Y)
2023-02-17 17:01:27 -08:00
Nick Briggs
dc893dda99
Make local procedures map_code_pointers() and remimplicitkeyhash() static and remove from gccodedefs.h
2023-02-17 17:01:27 -08:00
Nick Briggs
26737f3cbf
Resolve warning: no previous extern declaration for non-static variable in gccode.c
2023-02-17 17:01:27 -08:00
Nick Briggs
235246ded3
Resolve warning: no previous extern declaration for non-static variable by making locals static.
2023-02-17 17:01:27 -08:00
Nick Briggs
6603957a0b
Move extern declaration for IOINTERRUPTFLAGS_word to lspglob.h and remove from initsout.c
...
Initialize MaxTypeNumber_word from address of value cell of \MaxTypeNumber in initsout.c
Correctly extract value of \MaxTypeNumber where used in gcmaptable() (though gcmaptable() itself is unused at this time)
Update GetDTD() macro to return (void *), result will be cast to (struct dtd *) where it is needed. Alignment should always be sufficiently large.
2023-02-17 17:01:27 -08:00
Nick Briggs
6158162b62
Make local variables static to resolve warning: no previous extern declaration for non-static variable
2023-02-17 17:01:27 -08:00
Nick Briggs
13cd97ad41
Resolve warning: no previous extern declaration for non-static variable in ufs.c
2023-02-17 17:01:27 -08:00
Nick Briggs
215d4ff8c7
Make local variables static to resolve warning: no previous extern declaration for non-static variable
2023-02-17 17:01:27 -08:00
Nick Briggs
4b0eea260f
Resolve warning: no previous extern declaration for non-static variable.
...
Declare ether broadcast address constant.
2023-02-17 17:01:27 -08:00
Nick Briggs
97cca299be
Remove unused variable and resolve warning: no previous extern declaration for non-static variable in xc.c
2023-02-17 17:01:27 -08:00
Nick Briggs
904f5b4d3d
Resolve warning: no previous extern declaration for non-static variable in lineblt8.c
2023-02-17 17:01:27 -08:00
Nick Briggs
2b126bd083
Resolve warning: no previous extern declaration for non-static variable in timer.c
...
Remove unreferenced extern LispWindowFd
2023-02-17 17:01:27 -08:00
Nick Briggs
ea022aa61c
Resolve warning: no previous extern declaration for non-static variable in llcolor.c
2023-02-17 17:01:27 -08:00
Nick Briggs
a06e4c949d
Move temporary colormap variables to stack allocated in the only routine in which they are used
2023-02-17 17:01:27 -08:00
Nick Briggs
d84f85c7e0
Remove local variables no longer needed for debugging.
2023-02-17 17:01:27 -08:00
Nick Briggs
526e559c8d
Declare module local variables static in loopsops.c
2023-02-17 17:01:27 -08:00
Nick Briggs
cb441fd8e5
Declare local table generic_X_keymap static and constant, and adjust reference to it.
2023-02-17 17:01:27 -08:00
Nick Briggs
f18295480f
Resolve warning: no previous extern declaration for non-static variable in initkbd.c
2023-02-17 17:01:27 -08:00
Nick Briggs
9d40ecd77a
Update commentary for LispKbdFd, remove unused LispWindowFd extern reference
2023-02-17 17:01:27 -08:00
Nick Briggs
ade2b1461a
Correct declared type of LispWindowFd and LispKbdFd
2023-02-17 17:01:27 -08:00
Nick Briggs
ce97f136ec
Declare unexported variables static and remove unused debug-related variables.
2023-02-17 17:01:27 -08:00
Nick Briggs
bb1b541014
Add extern declarations for globals defined in xlspwin.c
2023-02-17 17:01:27 -08:00
Nick Briggs
7e2620db20
Remove extraneous forward declaration of contextsw()
2023-02-17 17:01:27 -08:00
Nick Briggs
50f88d9f05
Fix typo in comments, upnt => punt
2023-02-17 17:01:27 -08:00
Nick Briggs
b85e7cac80
Use (void *) casts in adr68k.h functions, after ensuring correct pointer alignment, to eliminate spurious alignment warnings.
2023-02-17 17:01:27 -08:00
Nick Briggs
679b201849
Remove unused #defines
2023-02-17 17:01:27 -08:00
Nick Briggs
7eb3cd0ceb
Address alignment warnings for createcell68k()
...
createcell68k(typecode) returns a pointer that is aligned for the typecode
argument. Changing the return type to "void *" puts the onus on the caller
to cast the result to an appropriately aligned object. All current uses
in the maiko source ask for 4-byte objects (TYPE_FIXP, TYPE_FLOATP).
2023-02-17 17:01:27 -08:00
Nick Briggs
9bfeaeb8b4
Resolve warning because URaid_comm string as a target of a sscanf() must have space for a terminating NUL
2023-02-17 17:01:27 -08:00
Nick Briggs
7eb87576f5
cursorlist and cursor fore/background colors are local to module and can be static.
2023-02-17 17:01:27 -08:00
Nick Briggs
4b3997b432
The todo_... variables are not referenced elsewhere and can be static.
2023-02-17 17:01:27 -08:00
Nick Briggs
a536faa736
Reduce missing-variable-declarations, move some atom index extern definitions to lspglob.h.
2023-02-17 17:01:27 -08:00
Nick Briggs
4834f6f2b1
Eliminate various warnings from vmemsave.c/vmemsavedefs.h
...
* sort_fptovp() and twowords() can be static and are sometimes (depending on flags)
not needed at all
* roundup() macro is unused and can be removed
* maxpages can be unsigned (affects main.c)
* variables used for return values of system calls should be correctly declared
* pointers into Lisp_world should be DLword* rather than char*, and
computations must take that into account.
* ENOSPC and EDQUOT errors on write should return NOFILESPACE instead of FILECANNOTWRITE error.
2023-02-17 17:01:27 -08:00
Nick Briggs
766de557bb
Cleanup warnings from byte swapping routines
2023-02-17 17:01:27 -08:00
Nick Briggs
d98df4f8d3
Remove extra MState macro and replace MState(&MachineState)->x with a direct MachineState.x field access.
2023-02-17 17:01:27 -08:00
Nick Briggs
6b41fcea17
Use PVar macro rather than directly referencing MState->pvar; MState itself is another macro.
2023-02-17 17:01:27 -08:00
Nick Briggs
a17460cd6b
Remove unused atom_to_str() function and the warning it generates
2023-02-17 17:01:27 -08:00
Nick Briggs
55939e0bc9
Resolve warning: variable '...' may be uninitialized when used here in new_bitblt_code
...
Note that one might analyze the order of the variables in the bitblt inner loops and
adjust so that items accessed together are in the same cache-line.
2023-02-17 17:01:27 -08:00
Nick Briggs
960baf9b96
fix signedness issue in N_OP_bind(unused), matching correction made in inlineC.h BIND in 26e67a51
2023-02-17 17:01:27 -08:00
Nick Briggs
5c81ca3f41
Resolve warning: 'DOS' (and 'SUNDISPLAY') is not defined, evaluates to 0; use #ifdef/#if defined(...)
2023-02-17 17:01:27 -08:00
Nick Briggs
38761fbd93
Resolve warning: unreachable-code-break (remove break following return)
2023-02-17 17:01:27 -08:00
Nick Briggs
7b67b3f79f
Use in_display_segment(...) macro where possible.
2023-02-17 17:01:27 -08:00
