github.com/open-simh.simh
1
0
Fork 0
mirror of https://github.com/open-simh/simh.git synced 2026-04-25 20:01:33 +00:00
Code Issues Projects Releases Wiki Activity

H316, I7094, NOVA, PDP1, PDP10, PDP8, SDS: Coverity singleton errors

Browse Source 
Most history routines defined a local sim_eval of the proper length, but the
erroneous ones were fixed length machines that defined an integer variable
instead of an integer array of length 1. The VAX used the global sim_eval.
The changes follow the VAX practice.
This commit is contained in:
Bob Supnik
2017-09-07 09:59:04 -07:00
committed by Mark Pizzolato
parent e9d5e2e3c9
commit 5b5e0f9c35
7 changed files with 26 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
SDS/sds_cpu.c
View File

@@ -26,6 +26,7 @@
cpu central processor
rtc real time clock
07-Sep-17 RMS Fixed sim_eval declaration in history routine (COVERITY)
09-Mar-17 RMS trap_P not set if mem mgt trap during fetch (COVERITY)
28-Apr-07 RMS Removed clock initialization
29-Dec-06 RMS Fixed breakpoint variable declarations
@@ -1865,7 +1866,6 @@ t_stat cpu_show_hist (FILE *st, UNIT *uptr, int32 val, CONST void *desc)
int32 ov, k, di, lnt;
const char *cptr = (const char *) desc;
t_stat r;
t_value sim_eval;
InstHistory *h;
static const char *cyc[] = { " ", " ", "INT", "TRP" };
static const char *modes = "NMU?";
@@ -1891,8 +1891,8 @@ for (k = 0; k < lnt; k++) { /* print specified */
if (h->ea & HIST_NOEA)
fprintf (st, " ");
else fprintf (st, "%05o ", h->ea);
sim_eval = h->ir;
if ((fprint_sym (st, h->pc, &sim_eval, &cpu_unit, SWMASK ('M'))) > 0)
sim_eval[0] = h->ir;
if ((fprint_sym (st, h->pc, sim_eval, &cpu_unit, SWMASK ('M'))) > 0)
fprintf (st, "(undefined) %08o", h->ir);
fputc ('\n', st); /* end line */
} /* end else instruction */