github.com/wfjm.w11
1
0
Fork 0
mirror of https://github.com/wfjm/w11.git synced 2026-01-14 07:50:08 +00:00
Code Issues Releases Wiki Activity

cleanups for -Wpedantic; bugfix in RtclArgs.hpp

Browse Source
This commit is contained in:
wfjm 2018-09-28 19:51:19 +02:00
parent 700eb2349c
commit 970be66d07
24 changed files with 92 additions and 90 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
doc/CHANGELOG.md
View File

@ -31,6 +31,7 @@ The full set of tests is only run for tagged releases.
- RtclRw11Unit: fix for clang: M_virt() now public
### Bug Fixes
- RtclArgs.hpp: BUGFIX: get *_min limits correct (gcc -Wpedantic)
- RtclArgs.cpp: BUGFIX: GetArg(): argument in wrong order (coverity)
- Rw11CntlDEUNA.cpp: BUGFIX: SetMacDefault(): resource leak (coverity)
- Rw11VirtDiskFile.cpp: BUGFIX: Open(): resource leak (coverity)

6
tools/src/librlink/ReventLoop.cpp
View File

@ -1,6 +1,6 @@
// $Id: ReventLoop.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: ReventLoop.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -185,7 +185,7 @@ void ReventLoop::EventLoop()
//! FIXME_docs
void ReventLoop::Dump(std::ostream& os, int ind, const char* text,
int detail) const
int /*detail*/) const
{
RosFill bl(ind);
os << bl << (text?text:"--") << "ReventLoop @ " << this << endl;

6
tools/src/librlink/RlinkChannel.cpp
View File

@ -1,6 +1,6 @@
// $Id: RlinkChannel.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RlinkChannel.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -68,7 +68,7 @@ bool RlinkChannel::Exec(RlinkCommandList& clist, RerrMsg& emsg)
//! FIXME_docs
void RlinkChannel::Dump(std::ostream& os, int ind, const char* text,
int detail) const
int /*detail*/) const
{
RosFill bl(ind);
os << bl << (text?text:"--") << "RlinkChannel @ " << this << endl;

6
tools/src/librlink/RlinkCommandExpect.cpp
View File

@ -1,6 +1,6 @@
// $Id: RlinkCommandExpect.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RlinkCommandExpect.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2011-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2011-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -134,7 +134,7 @@ bool RlinkCommandExpect::BlockIsChecked(size_t ind) const
//! FIXME_docs
void RlinkCommandExpect::Dump(std::ostream& os, int ind, const char* text,
int detail) const
int /*detail*/) const
{
RosFill bl(ind);
os << bl << (text?text:"--") << "RlinkCommandExpect @ " << this << endl;

6
tools/src/librlink/RlinkContext.cpp
View File

@ -1,6 +1,6 @@
// $Id: RlinkContext.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RlinkContext.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -57,7 +57,7 @@ RlinkContext::~RlinkContext()
//! FIXME_docs
void RlinkContext::Dump(std::ostream& os, int ind, const char* text,
int detail) const
int /*detail*/) const
{
RosFill bl(ind);
os << bl << (text?text:"--") << "RlinkContext @ " << this << endl;

6
tools/src/librlinktpp/RtclAttnShuttle.cpp
View File

@ -1,6 +1,6 @@
// $Id: RtclAttnShuttle.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RtclAttnShuttle.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2014 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -142,7 +142,7 @@ int RtclAttnShuttle::AttnHandler(RlinkServer::AttnArgs& args)
//------------------------------------------+-----------------------------------
//! FIXME_docs
void RtclAttnShuttle::TclChannelHandler(int mask)
void RtclAttnShuttle::TclChannelHandler(int /*mask*/)
{
uint16_t apat;
Tcl_ReadRaw(fShuttleChn, (char*) &apat, sizeof(apat));

6
tools/src/librtcltools/Rtcl.hpp
View File

@ -1,6 +1,6 @@
// $Id: Rtcl.hpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rtcl.hpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2011-2013 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2011-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -56,7 +56,7 @@ namespace Retro {
void SetResult(Tcl_Interp* interp, const std::string& str);
void SetResult(Tcl_Interp* interp, std::ostringstream& sos);
};
}
} // end namespace Retro

23
tools/src/librtcltools/RtclArgs.hpp
View File

@ -1,6 +1,6 @@
// $Id: RtclArgs.hpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RtclArgs.hpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2011-2013 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2011-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -13,6 +13,7 @@
//
// Revision History:
// Date Rev Version Comment
// 2018-09-22 1049 1.0.10 BUGFIX: get *_min limits correct
// 2013-05-19 521 1.0.9 add NextSubOpt() method, pass optset's as const
// 2013-03-05 495 1.0.8 add SetResult(bool)
// 2013-03-02 494 1.0.7 add Quit() method
@ -50,15 +51,15 @@ namespace Retro {
class RtclArgs {
public:
const static int8_t int8_min = 0xff;
const static int8_t int8_max = 0x7f;
const static uint8_t uint8_max = 0xff;
const static int16_t int16_min = 0xffff;
const static int16_t int16_max = 0x7fff;
const static uint16_t uint16_max = 0xffff;
const static int32_t int32_min = 0xffffffff;
const static int32_t int32_max = 0x7fffffff;
const static uint32_t uint32_max = 0xffffffff;
const static int8_t int8_min = std::numeric_limits<int8_t>::min();
const static int8_t int8_max = std::numeric_limits<int8_t>::max();
const static uint8_t uint8_max = std::numeric_limits<uint8_t>::max();
const static int16_t int16_min = std::numeric_limits<int16_t>::min();
const static int16_t int16_max = std::numeric_limits<int16_t>::max();
const static uint16_t uint16_max = std::numeric_limits<uint16_t>::max();
const static int32_t int32_min = std::numeric_limits<int32_t>::min();
const static int32_t int32_max = std::numeric_limits<int32_t>::max();
const static uint32_t uint32_max = std::numeric_limits<uint32_t>::max();
RtclArgs();
RtclArgs(Tcl_Interp* interp, int objc,

10
tools/src/librutiltpp/RtclSignalAction.cpp
View File

@ -1,6 +1,6 @@
// $Id: RtclSignalAction.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RtclSignalAction.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2014 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -160,7 +160,7 @@ bool RtclSignalAction::ValidSignal(int signum, RerrMsg& emsg)
//------------------------------------------+-----------------------------------
//! FIXME_docs
void RtclSignalAction::TclChannelHandler(int mask)
void RtclSignalAction::TclChannelHandler(int /*mask*/)
{
char signum;
Tcl_Read(fShuttleChn, (char*) &signum, sizeof(signum));
@ -198,7 +198,7 @@ void RtclSignalAction::SignalHandler(int signum)
//------------------------------------------+-----------------------------------
//! FIXME_docs
void RtclSignalAction::ThunkTclChannelHandler(ClientData cdata, int mask)
void RtclSignalAction::ThunkTclChannelHandler(ClientData /*cdata*/, int mask)
{
if (fpObj) fpObj->TclChannelHandler(mask);
return;
@ -207,7 +207,7 @@ void RtclSignalAction::ThunkTclChannelHandler(ClientData cdata, int mask)
//------------------------------------------+-----------------------------------
//! FIXME_docs
void RtclSignalAction::ThunkTclExitProc(ClientData cdata)
void RtclSignalAction::ThunkTclExitProc(ClientData /*cdata*/)
{
delete fpObj;
fpObj = nullptr;

10
tools/src/librutiltpp/RtclSystem.cpp
View File

@ -1,6 +1,6 @@
// $Id: RtclSystem.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: RtclSystem.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2014 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -69,7 +69,7 @@ void RtclSystem::CreateCmds(Tcl_Interp* interp)
//------------------------------------------+-----------------------------------
//! FIXME_docs
int RtclSystem::Isatty(ClientData cdata, Tcl_Interp* interp,
int RtclSystem::Isatty(ClientData /*cdata*/, Tcl_Interp* interp,
int objc, Tcl_Obj* const objv[])
{
RtclArgs args(interp, objc, objv);
@ -116,7 +116,7 @@ static const char* signum2nam(int signum)
//------------------------------------------+-----------------------------------
//! FIXME_docs
int RtclSystem::SignalAction(ClientData cdata, Tcl_Interp* interp,
int RtclSystem::SignalAction(ClientData /*cdata*/, Tcl_Interp* interp,
int objc, Tcl_Obj* const objv[])
{
RtclArgs args(interp, objc, objv);
@ -210,7 +210,7 @@ int RtclSystem::SignalAction(ClientData cdata, Tcl_Interp* interp,
//------------------------------------------+-----------------------------------
//! FIXME_docs
int RtclSystem::WaitPid(ClientData cdata, Tcl_Interp* interp,
int RtclSystem::WaitPid(ClientData /*cdata*/, Tcl_Interp* interp,
int objc, Tcl_Obj* const objv[])
{
RtclArgs args(interp, objc, objv);

6
tools/src/librw11/Rw11.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -117,7 +117,7 @@ void Rw11::Start()
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11::Dump(std::ostream& os, int ind, const char* text, int detail) const
void Rw11::Dump(std::ostream& os, int ind, const char* text, int /*detail*/) const
{
RosFill bl(ind);
os << bl << (text?text:"--") << "Rw11 @ " << this << endl;

6
tools/src/librw11/Rw11Cntl.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11Cntl.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11Cntl.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -98,7 +98,7 @@ void Rw11Cntl::Start()
//------------------------------------------+-----------------------------------
//! FIXME_docs
bool Rw11Cntl::BootCode(size_t unit, std::vector<uint16_t>& code,
bool Rw11Cntl::BootCode(size_t /*unit*/, std::vector<uint16_t>& code,
uint16_t& aload, uint16_t& astart)
{
code.clear();

20
tools/src/librw11/Rw11CntlDEUNA.cpp
View File

@ -1,4 +1,4 @@
// $Id: Rw11CntlDEUNA.cpp 1048 2018-09-22 07:41:46Z mueller $
// $Id: Rw11CntlDEUNA.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2014-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
@ -350,7 +350,7 @@ void Rw11CntlDEUNA::Start()
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11CntlDEUNA::UnitSetup(size_t ind)
void Rw11CntlDEUNA::UnitSetup(size_t /*ind*/)
{
RlinkCommandList clist;
Rw11Cpu& cpu = Cpu();
@ -1365,10 +1365,10 @@ void Rw11CntlDEUNA::StartTxRing()
RlinkCommandList clist;
uint16_t txdsccur[4];
uint16_t txdscnxt[4];
size_t irdtxdsccur = Cpu().AddRMem(clist, TxRingDscAddr(fTxRingIndex),
txdsccur, 3, Rw11Cpu::kCPAH_M_UBM22, true);
size_t irdtxdscnxt = Cpu().AddRMem(clist, TxRingDscAddr(TxRingIndexNext()),
txdscnxt, 3, Rw11Cpu::kCPAH_M_UBM22, true);
//size_t irdtxdsccur = Cpu().AddRMem(clist, TxRingDscAddr(fTxRingIndex),
// txdsccur, 3, Rw11Cpu::kCPAH_M_UBM22, true);
//size_t irdtxdscnxt = Cpu().AddRMem(clist, TxRingDscAddr(TxRingIndexNext()),
// txdscnxt, 3, Rw11Cpu::kCPAH_M_UBM22, true);
Server().Exec(clist);
// FIXME_code: check dsc read errors !
StartTxRing(txdsccur, txdscnxt);
@ -1408,10 +1408,10 @@ void Rw11CntlDEUNA::StartRxRing()
RlinkCommandList clist;
uint16_t rxdsccur[4];
uint16_t rxdscnxt[4];
size_t irdrxdsccur = Cpu().AddRMem(clist, RxRingDscAddr(fRxRingIndex),
rxdsccur, 3, Rw11Cpu::kCPAH_M_UBM22, true);
size_t irdrxdscnxt = Cpu().AddRMem(clist, RxRingDscAddr(RxRingIndexNext()),
rxdscnxt, 3, Rw11Cpu::kCPAH_M_UBM22, true);
//size_t irdrxdsccur = Cpu().AddRMem(clist, RxRingDscAddr(fRxRingIndex),
// rxdsccur, 3, Rw11Cpu::kCPAH_M_UBM22, true);
//size_t irdrxdscnxt = Cpu().AddRMem(clist, RxRingDscAddr(RxRingIndexNext()),
// rxdscnxt, 3, Rw11Cpu::kCPAH_M_UBM22, true);
Server().Exec(clist);
// FIXME_code: check dsc read errors !
StartRxRing(rxdsccur, rxdscnxt);

6
tools/src/librw11/Rw11CntlDL11.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11CntlDL11.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11CntlDL11.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -132,7 +132,7 @@ void Rw11CntlDL11::Start()
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11CntlDL11::UnitSetup(size_t ind)
void Rw11CntlDL11::UnitSetup(size_t /*ind*/)
{
Rw11Cpu& cpu = Cpu();
uint16_t rcsr = (fRxRlim<<kRCSR_V_RXRLIM) & kRCSR_M_RXRLIM;

6
tools/src/librw11/Rw11CntlPC11.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11CntlPC11.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11CntlPC11.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -132,7 +132,7 @@ void Rw11CntlPC11::Start()
//------------------------------------------+-----------------------------------
//! FIXME_docs
bool Rw11CntlPC11::BootCode(size_t unit, std::vector<uint16_t>& code,
bool Rw11CntlPC11::BootCode(size_t /*unit*/, std::vector<uint16_t>& code,
uint16_t& aload, uint16_t& astart)
{
uint16_t kBOOT_START = 0017476;

10
tools/src/librw11/Rw11CntlTM11.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11CntlTM11.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11CntlTM11.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2015-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2015-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Other credits:
// the boot code is from the simh project and Copyright Robert M Supnik
//
@ -452,8 +452,8 @@ int Rw11CntlTM11::AttnHandler(RlinkServer::AttnArgs& args)
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11CntlTM11::RdmaPreExecCB(int stat, size_t nwdone, size_t nwnext,
RlinkCommandList& clist)
void Rw11CntlTM11::RdmaPreExecCB(int /*stat*/, size_t /*nwdone*/,
size_t /*nwnext*/, RlinkCommandList& /*clist*/)
{
// noop for TM11
return;
@ -463,7 +463,7 @@ void Rw11CntlTM11::RdmaPreExecCB(int stat, size_t nwdone, size_t nwnext,
//! FIXME_docs
void Rw11CntlTM11::RdmaPostExecCB(int stat, size_t ndone,
RlinkCommandList& clist, size_t ncmd)
RlinkCommandList& /*clist*/, size_t /*ncmd*/)
{
if (stat == Rw11Rdma::kStatusBusy) return;

6
tools/src/librw11/Rw11Probe.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11Probe.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11Probe.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -89,7 +89,7 @@ char Rw11Probe::IndicatorRem() const
//! FIXME_docs
void Rw11Probe::Dump(std::ostream& os, int ind, const char* text,
int detail) const
int /*detail*/) const
{
RosFill bl(ind);
os << bl << (text?text:"--") << "Rw11Probe @ " << this << endl;

6
tools/src/librw11/Rw11Rdma.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11Rdma.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11Rdma.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2015-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2015-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -228,7 +228,7 @@ void Rw11Rdma::PreRdmaHook()
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11Rdma::PostRdmaHook(size_t nwdone)
void Rw11Rdma::PostRdmaHook(size_t /*nwdone*/)
{
return;
}

6
tools/src/librw11/Rw11Unit.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11Unit.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11Unit.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -89,7 +89,7 @@ const std::string& Rw11Unit::AttachUrl() const
//------------------------------------------+-----------------------------------
//! FIXME_docs
bool Rw11Unit::Attach(const std::string& url, RerrMsg& emsg)
bool Rw11Unit::Attach(const std::string& /*url*/, RerrMsg& emsg)
{
emsg.Init("Rw11Unit::Attach","attach not available for this device type");
return false;

6
tools/src/librw11/Rw11UnitDisk.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11UnitDisk.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11UnitDisk.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -62,7 +62,7 @@ Rw11UnitDisk::~Rw11UnitDisk()
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11UnitDisk::SetType(const std::string& type)
void Rw11UnitDisk::SetType(const std::string& /*type*/)
{
throw Rexception("Rw11UnitDisk::SetType",
string("Bad args: only type '") + fType + "' supported");

6
tools/src/librw11/Rw11UnitTape.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11UnitTape.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11UnitTape.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2015-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2015-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -57,7 +57,7 @@ Rw11UnitTape::~Rw11UnitTape()
//------------------------------------------+-----------------------------------
//! FIXME_docs
void Rw11UnitTape::SetType(const std::string& type)
void Rw11UnitTape::SetType(const std::string& /*type*/)
{
throw Rexception("Rw11UnitTape::SetType",
string("Bad args: only type '") + fType + "' supported");

6
tools/src/librw11/Rw11VirtDiskOver.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11VirtDiskOver.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11VirtDiskOver.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2017- by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2017-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -116,7 +116,7 @@ bool Rw11VirtDiskOver::Read(size_t lba, size_t nblk, uint8_t* data,
//! FIXME_docs
bool Rw11VirtDiskOver::Write(size_t lba, size_t nblk, const uint8_t* data,
RerrMsg& emsg)
RerrMsg& /*emsg*/)
{
fStats.Inc(kStatNVDOWrite);
fStats.Inc(kStatNVDOWriteBlk, double(nblk));

6
tools/src/librw11/Rw11VirtTermTcp.cpp
View File

@ -1,6 +1,6 @@
// $Id: Rw11VirtTermTcp.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: Rw11VirtTermTcp.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013-2017 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -188,7 +188,7 @@ bool Rw11VirtTermTcp::Open(const std::string& url, RerrMsg& emsg)
//------------------------------------------+-----------------------------------
//! FIXME_docs
bool Rw11VirtTermTcp::Snd(const uint8_t* data, size_t count, RerrMsg& emsg)
bool Rw11VirtTermTcp::Snd(const uint8_t* data, size_t count, RerrMsg& /*emsg*/)
{
fStats.Inc(kStatNVTSnd);
const uint8_t* pdata = data;

6
tools/src/testtclsh/testtclsh.cpp
View File

@ -1,6 +1,6 @@
// $Id: testtclsh.cpp 983 2018-01-02 20:35:59Z mueller $
// $Id: testtclsh.cpp 1049 2018-09-22 13:56:52Z mueller $
//
// Copyright 2013- by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
// Copyright 2013-2018 by Walter F.J. Mueller <W.F.J.Mueller@gsi.de>
//
// This program is free software; you may redistribute and/or modify it under
// the terms of the GNU General Public License as published by the Free
@ -32,7 +32,7 @@ extern "C" int Rlinktpp_Init(Tcl_Interp* interp);
//extern "C" int Rusbtpp_Init(Tcl_Interp* interp);
extern "C" int Rwxxtpp_Init(Tcl_Interp* interp);
int main(int argc, const char* argv[])
int main(int /*argc*/, const char* /*argv*/[])
{
cout << "testtclsh starting..." << endl;