github.com/xen-tools.xen-tools
1
0
Fork 0
mirror of synced 2026-02-18 12:56:55 +00:00
Code Releases Activity

Remove trailing space from make_fs_ options.

Browse Source 
The "-d name=" option doesn't appear as necessary with mkfs.xfs, at
least with version 3.1.2 of mkfs.xfs (of course, tested with a file
instead of a device).
This simplifies a TODO item.
This commit is contained in:
Stéphane Jourdois
2010-07-23 23:03:57 +02:00
committed by Axel Beckert
parent 669b4c8f4f
commit 64c9c8398b
2 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
TODO
View File

@@ -15,8 +15,7 @@ Minor bugs to fix and features to add before a 4.2 release
* Test and support more file system types.
Actually this should be pretty simple now that the parameters are
stored in the configuration hash. The only issue is that trailing
whitespace is missing from the "make_fs_foo" option.
stored in the configuration hash.
* Setup locales in the hooks?

12
bin/xen-create-image
View File

@@ -1397,11 +1397,11 @@ sub setupDefaultOptions
# filesystem, even if it exists. This script must detect
# prior existance itself.
#
$CONFIG{ 'make_fs_ext2' } = 'mkfs.ext2 -F ';
$CONFIG{ 'make_fs_ext3' } = 'mkfs.ext3 -F ';
$CONFIG{ 'make_fs_ext4' } = 'mkfs.ext4 -F ';
$CONFIG{ 'make_fs_xfs' } = 'mkfs.xfs -f -d name=';
$CONFIG{ 'make_fs_reiserfs' } = 'mkfs.reiserfs -f -q ';
$CONFIG{ 'make_fs_ext2' } = 'mkfs.ext2 -F';
$CONFIG{ 'make_fs_ext3' } = 'mkfs.ext3 -F';
$CONFIG{ 'make_fs_ext4' } = 'mkfs.ext4 -F';
$CONFIG{ 'make_fs_xfs' } = 'mkfs.xfs -f';
$CONFIG{ 'make_fs_reiserfs' } = 'mkfs.reiserfs -f -q';
#
# Flags to pass to "mount" to mount our image.
@@ -3358,7 +3358,7 @@ sub createFilesystem
#
logprint("\nCreating $fs filesystem on $image\n");
$command .= $image;
$command .= " " . $image;
runCommand($command);
logprint("Done\n");