1
0
mirror of https://github.com/antonblanchard/microwatt.git synced 2026-01-21 10:02:44 +00:00

187 Commits

Author SHA1 Message Date
Anton Blanchard
555802d996
Merge pull request #74 from paulusmack/divider
Divider
2019-09-28 14:32:14 +10:00
Paul Mackerras
25b9450475 divider: Do absolute-value ops in divider instead of decode
This moves the negation of negative operands for signed divide and
modulus operations out of the decode2 stage and into the divider.
If either of the operands for a signed divide or modulus operation
is negative, the divider now takes an extra cycle to negate the
operands that are negative.

The interface to the divider now has an 'is_signed' signal rather
than a 'neg_result' signal, and the dividend and divisor can be
negative, so divider_tb had to be updated for the new interface.

The reason for doing this is that one of the worst timing violations
on the Arty A7-100 at 100MHz involved the carry chain in the adders
that did the negation of the dividend and divisor in the decode stage.
Moving the negations to a separate cycle fixes that and also seems to
reduce the total number of slice LUTs used.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
2019-09-28 08:55:08 +10:00
Paul Mackerras
e6536d4b8b divider: Always compute result/sresult/d_out.write_reg_data
These are intended to be combinatorial.  The previous code was giving
warnings in vivado about registers/latches with no clock defined.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
2019-09-28 08:41:17 +10:00
Anton Blanchard
ad040601e6
Merge pull request #73 from antonblanchard/remove-divide-patch
Remove gcc software divide patch
2019-09-25 09:13:18 +10:00
Anton Blanchard
c8328cdf84 Remove gcc software divide patch
We have a divider, thanks to Paul.

Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-25 08:03:10 +10:00
Anton Blanchard
82fe8dc6e2
Merge pull request #72 from antonblanchard/build-error
Fix build issue in dmi_dtm_dummy.vhdl
2019-09-24 20:54:28 +10:00
Anton Blanchard
a9e5fe78fb
Merge pull request #71 from antonblanchard/dependencies
Update Makefile dependencies
2019-09-24 20:34:52 +10:00
Anton Blanchard
8102e7863b Fix build issue in dmi_dtm_dummy.vhdl
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-24 20:27:34 +10:00
Anton Blanchard
26f70264b3 Update Makefile dependencies
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-24 17:50:17 +10:00
Anton Blanchard
b57325ce29 Merge branch 'divider' of https://github.com/paulusmack/microwatt 2019-09-24 17:33:21 +10:00
Anton Blanchard
cd4da50650
Merge pull request #70 from antonblanchard/badly-named-carry
Rename OP_SUBFC -> OP_SUBFE, OP_ADDC -> OP_ADDE
2019-09-24 17:25:44 +10:00
Anton Blanchard
5a6f8d26d1 Rename OP_SUBFC -> OP_SUBFE, OP_ADDC -> OP_ADDE
These were somewhat badly named.

Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-24 16:55:09 +10:00
Anton Blanchard
ba783fddd5
Merge pull request #69 from antonblanchard/debug-module
Merge debug module patches
2019-09-24 16:51:03 +10:00
Anton Blanchard
6cae10eebd Terminate test on illegal instruction
This gets the CI going again, but we will want to fix the test
harness since it's useful to be able to debug the core after it
executes an illegal instruction.

Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-23 21:22:18 +10:00
Anton Blanchard
8c5dcc8c4c Fix ghdl error
I'm seeing an issue on my version of ghdl:

  core.vhdl:137:24:error: actual expression must be globally static

Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-23 21:20:12 +10:00
Anton Blanchard
d82f4c18b6 Add core_debug.vhdl to fusesoc configs
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-23 20:49:21 +10:00
Paul Mackerras
a01ffaeb64 Speed up the divider a little
This looks for cases where the next 8 bits of the quotient are obviously
going to be zero, because the top 72 bits of the 128-bit dividend
register are all zero.  In those cases we shift 8 zero bits into the
quotient and increase count by 8.  We only do this if count < 56.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
2019-09-23 14:39:50 +10:00
Paul Mackerras
d5bc6c8824 Add a divider unit and a testbench for it
This adds a divider unit, connected to the core in much the same way
that the multiplier unit is connected.  The division algorithm is
very simple-minded, taking 64 clock cycles for any division (even
32-bit division instructions).

The decoding is simplified by making use of regularities in the
instruction encoding for div* and mod* instructions.  Instead of
having PPC_* encodings from the first-stage decoder for each of the
different div* and mod* instructions, we now just have PPC_DIV and
PPC_MOD, and the inputs to the divider that indicate what sort of
division operation to do are derived from instruction word bits.

Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
2019-09-23 14:31:53 +10:00
Benjamin Herrenschmidt
42d802bed0 Add distclean to Makefile
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 16:46:31 +10:00
Benjamin Herrenschmidt
fe275effeb New C based JTAG debug tool
This works with both the sim socket and urjtag, and supports the
new core functions, loading a file in memory etc...

The code still needs a lot of cleanup and a help!

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 16:46:31 +10:00
Benjamin Herrenschmidt
98f0994698 Add core debug module
This module adds some simple core controls:

  reset, stop, start, step

along with icache clear and reading the NIA and core
status bits

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org
2019-09-20 16:45:50 +10:00
Benjamin Herrenschmidt
554b753172 Add jtag support in simulation via a socket
This adds a local socket that can be used to communicate with
the debug tool (which will be committed separately) and generates
the JTAG signals.

We generate the low level JTAG signals, thus directly driving the
simulated BSCANE2, and the Xilinx DTM

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 15:07:49 +10:00
Benjamin Herrenschmidt
ad14a41d80 Add DMI address decoder
And prepare signals for core DMI support

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 15:07:49 +10:00
Benjamin Herrenschmidt
b46f81fae4 Wishbone debug module
This adds a debug module off the DMI (debug) bus which can act as a
wishbone master to generate read and write cycles.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 15:07:49 +10:00
Benjamin Herrenschmidt
ee52fd4d80 Add a debug (DMI) bus and a JTAG interface to it on Xilinx FPGAs
This adds a simple bus that can be mastered from an external
system via JTAG, which will be used to hookup various debug
modules.

It's loosely based on the RiscV model (hence the DMI name).

The module currently only supports hooking up to a Xilinx BSCANE2
but it shouldn't be too hard to adapt it to support different TAPs
if necessary.

The JTAG protocol proper is not exactly the RiscV one at this point,
though I might still change it.

This comes with some sim variants of Xilinx BSCANE2 and BUFG and a
test bench.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 15:07:49 +10:00
Benjamin Herrenschmidt
1206dfe18c Use a 3 way WB arbiter and cleanup fpga toplevel
The 3rd master is currently unused, it will host the WB debug module.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
2019-09-20 15:07:47 +10:00
Anton Blanchard
6571b13308
Merge pull request #66 from antonblanchard/reformat-4
More reformatting
2019-09-19 22:49:41 +10:00
Anton Blanchard
7e7010c304 Reformat crhelpers, and remove some stale code
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 21:53:27 +10:00
Anton Blanchard
ae42370d24 Reformat helpers
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 21:53:09 +10:00
Anton Blanchard
9ff86a62f5 Reformat insn_helpers
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 21:52:07 +10:00
Anton Blanchard
c5d327cebf
Merge pull request #65 from antonblanchard/loadstore-opt
A small loadstore optimisation, and some reformatting
2019-09-19 21:48:22 +10:00
Anton Blanchard
687051ecbb Reformat loadstore1
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 21:37:43 +10:00
Anton Blanchard
6e442e07a5 Reformat loadstore2
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 21:36:51 +10:00
Anton Blanchard
e1a71e4545 loads don't do both byte reversal and sign extension
Give the synthesis tools a clue that we don't need to do both byte reversal
and sign extension.

Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 21:31:34 +10:00
Anton Blanchard
4df05e0598
Merge pull request #64 from antonblanchard/reformat-3
Reformat some more files
2019-09-19 21:07:31 +10:00
Anton Blanchard
48f4dcece8
Merge pull request #63 from antonblanchard/multiply-cleanup
Multiply cleanup
2019-09-19 20:36:26 +10:00
Anton Blanchard
df1165bdfc Reformat wishbone code
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:35:42 +10:00
Anton Blanchard
06392e7eaa Reformat glibc_random
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:33:58 +10:00
Anton Blanchard
1d5e8c2eb4 Reformat simple_ram_behavioural
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:32:07 +10:00
Anton Blanchard
fd9e971b2c Reformat sim_console
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:28:37 +10:00
Anton Blanchard
28e6d343dc Reformat multiply_tb
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:26:55 +10:00
Anton Blanchard
fc10935797 Reformat execute2
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:24:29 +10:00
Anton Blanchard
4d0afa3a6d Reformat CR file
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:22:36 +10:00
Anton Blanchard
4d9b2a1165 Reformat register file
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:21:58 +10:00
Anton Blanchard
8dd97fbe7f Reformat multiply code
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:19:46 +10:00
Anton Blanchard
99dd4de54e Don't use VHDL 2008 condition operator in multiply
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-19 20:18:01 +10:00
Anton Blanchard
550b2b8608
Merge pull request #62 from antonblanchard/byte-reverse-store-opt
Move byte reversal of stores to first cycle
2019-09-16 13:17:37 +10:00
Anton Blanchard
135805d2ac
Merge pull request #61 from antonblanchard/execute-cleanup
execute1 no longer needs sim_console
2019-09-16 13:14:25 +10:00
Anton Blanchard
a061924a78 Move byte reversal of stores to first cycle
We are seeing some timing issues with the second cycle of loadstore,
and  we aren't doing much in the first cycle, so move it here.

Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-16 11:49:44 +10:00
Anton Blanchard
6d85920068 execute1 no longer needs sim_console
Signed-off-by: Anton Blanchard <anton@linux.ibm.com>
2019-09-16 11:18:53 +10:00